MatthewKing / DeviceId

A simple library providing functionality to generate a 'device ID' that can be used to uniquely identify a computer.
MIT License
729 stars 118 forks source link

Trigger Nuget build #21

Closed techtim closed 3 years ago

techtim commented 3 years ago

The last version is 4 months old, please update Nuget with the latest commits for OSX

MatthewKing commented 3 years ago

Hi Tim,

I was waiting for some feedback from you (or another Mac user) on this issue as I'm not too familiar with OS X and I wasn't sure whether the IOPlatformSerialNumber would be better as a SystemUUID rather than a ProcessorId. Would really appreciate the expertise of a Mac user regarding the categorization of this component. Cheers!

techtim commented 3 years ago

Sorry, I didn't see your question in the PR. I didn't find the way to get exactly Processor Id on OSX, looks like there is none, so relying on Apple ID I found the most suitable to uniquely identify a mac, because people tend to use CPU id as the most unique variable available IOPlatformSerialNumber fits good. If use it for SystemUUID it will duplicate ProcessorId or ProcessorId will be empty

MatthewKing commented 3 years ago

Thanks mate, the feedback is appreciated. I've decided to add it to the OSInstallationID component, as it's technically not a processor ID. Hope that's alright for your use case. I'm triggering a build now, so it should show up on NuGet soon. Cheers!