search

MatthewKuKanich / FindMyFlipper

The FindMy Flipper app turns your FlipperZero into an AirTag or other tracking device, compatible with Apple AirTags and Samsung SmartTag and Tile Trackers. It uses the BLE beacon to broadcast, allowing users to clone existing tags, generate OpenHaystack key pairs for Apple's FindMy network, and customize beacon intervals and transmit power.
1.58k stars 51 forks source link

Fuzzier TXT file matching (or just a note in the readme) #98

Open Shrinks99 opened 2 months ago

Shrinks99 commented 2 months ago

Hey! Really cool project, was able to get everything set up both with the generated keys method and by cloning an existing tag! The guide in the readme is excellent.

The only issue I ran into during this process was the filename for the .txt file output from nrfConnect. My file was called XX_XX_XX_XX_XX_XX - YYYY-MM-DD HH_MM_SS.txt but this doesn't seem to match the format that the application expects.

Fortunately after searching for the error message in the codebase, I was able to find this helpful comment detailing the correct file name!

https://github.com/MatthewKuKanich/FindMyFlipper/blob/e5a678e33dd17af46bb63050be4c9d10e17f6252/FindMyFlipper/scenes/findmy_scene_config_import.c#L15

The fancier solution here would be to ensure the matching system can handle a few different common permutations (or just updating to this one if nrfConnect will always use it), but considering the audience I think just having a note in the readme with the correct format as part of the instructions would suffice and probably be the most bulletproof future solution :)

MatthewKuKanich commented 2 months ago

Thanks for this suggestion! I'll look into doing some form of input validation for both formats. It seems different versions of nrf Connect can format the file name differently. Thanks again!