search

MatthewPierson / 1033-OTA-Downgrader

First ever tool to downgrade ANY iPhone 5s, ANY iPad Air and (almost any) iPad Mini 2 to 10.3.3 with OTA blobs + checkm8!
497 stars 124 forks source link

Script doesn't stop on errors #14

Closed m1337v closed 5 years ago

m1337v commented 5 years ago

The script doesn't stop on errors like "file not found" and problems with the dependencies (brew link did not work for wget bc of permission problems). Had also some problems extracting from my ipsw as my system language was set to Russian and the Terminal did not recognize some Folders because of the cyrillic chracters.

The script just continued as if everything worked. After I found all errors manually and fixed them everything went fine

Bildschirmfoto 2019-10-13 um 02 33 10 Bildschirmfoto 2019-10-13 um 02 33 24

consllogluke commented 5 years ago

Stopping the script when there’s an error isn’t particularly ideal when using shell scripts from my understanding. You would need to check after every single command what the status of that command was which can get very tedious.

MatthewPierson commented 5 years ago

I might add a few more checks for specific errors but to add checks for everything is just not worth my time to be honest, when it already outputs when something didn't work (for the most part). As for the issues with cyrillic chracters and some folders, I have no idea how I would address that as I have no experience at all with cyrillic chracters and scripts. If you want to submit a pull request with any changes that you made for cyrillic chracters then feel free!

m1337v commented 5 years ago

I see your point the output should be enough with some general knowledge. Maybe the issue helps others discover that they need to check the log. The cyrillic characters are a very specific issue, fixed it by changing system language.

jeffreyvdhondel commented 5 years ago

Maybe you could set the LC_CTYPE/LC_ALL to prevent this issue with the cyrillic characters :)