MatthewRHermes / mrh

MRH's research code
Other
18 stars 30 forks source link

Managing subproblem hyperparameters in LASSCF async #104

Closed MatthewRHermes closed 2 months ago

MatthewRHermes commented 3 months ago

It's not straightforward to set the hyperparameters (max_cycle_macro, tol, etc.) of the impurity and "LASCI" subproblems in the LASSCF asynchronous algorithm. The "LASCI" subproblem in particular uses a dangerous __dict__.update call which forces max_cycle_macro of the calling problem and the subproblem to be the same value, despite them playing different roles.

MatthewRHermes commented 2 months ago

Not super happy with how inelegant this is but it works