search

MatthewVance / stubby-docker

Run Stubby without losing the performance benefits of having a local caching DNS resolver.
MIT License
94 stars 28 forks source link

Removed 128-bit integer compilation flag #7

Closed Knetic closed 4 years ago

Knetic commented 5 years ago

While trying to run this on a fresh Raspberry Pi, I kept running into an error during the ./config section of the docker build process - I don't have the exact message on me anymore, but it was to the effect of "128-bit integers are not supported on this configuration". After googling around, it seems that ARM gcc simply does not support 128-bit integers.

After removing the enable-ec_nistp_64_gcc_128 flag from both builds, it all worked great. The OpenSSL site seems to indicate that this flag is mostly for performance gains where available, and that it doesn't have a good way to detect if the flag should be used or not.

I'm not sure that removing it wholesale is the right move, but it worked for me, and seems to have no ill effect (on a Pi, at least).

MatthewVance commented 5 years ago

Thanks. I appreciate you making this change and testing on the Pi. I'm actually surprised this worked on the Pi at all without further modifications. On my normal Unbound, I keep a separate repo for the Pi.

I agree this shouldn't be too much of an issue. I ran across something similar on the nginx-build script. To avoid the performance penalty on devices that support it, would you mind re-submitting the PR with conditional logic? See here for an example: https://github.com/MatthewVance/nginx-build/commit/7290b2745dd8b78d276cbe7e158ec9691f920899