MatthewVance / unbound-docker

Unbound DNS Server Docker Image
MIT License
585 stars 142 forks source link

Add support for ARM64 #58

Open pedantic79 opened 3 years ago

pedantic79 commented 3 years ago

It would be great if you added support for ARM and ARM64 to your images. I used your Dockerfile to build it on my raspberrypi, but it would be great if they were available on Docker Hub.

MatthewVance commented 3 years ago

Yes, I need to now that I made this image compatible for both architectures. There is a separate repo for Pi that I need to depreciate. You can pull from it: https://github.com/MatthewVance/unbound-docker-rpi

On Sat, Jan 23, 2021, 3:54 PM pedantic79 notifications@github.com wrote:

It would be great if you added support for ARM and ARM64 to your images. I used your Dockerfile to build it on my raspberrypi, but it would be great if they were available on Docker Hub.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/MatthewVance/unbound-docker/issues/58, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAUMHOTBPHG3RYKZNGEP3FTS3NARTANCNFSM4WQADN7A .

pedantic79 commented 3 years ago

I'm running 64-bit Raspberry Pi OS (trying to utilize all 8GB on the pi4 that I have), so the mvance/unbound-rpi image still won't work for me. A quick look at the 1.13 directories from both repos, I didn't see too many important differences.

pedantic79 commented 3 years ago

I added a GHActions to my fork to build it for arm64 and amd64. Building arm64 is quite slow (probably due to being emulated), and takes over an hour.

https://github.com/pedantic79/unbound-docker/commit/21d20faf5a78cd13e5c4c5d03a0056acef5ef634

goose-ws commented 3 years ago

Just voicing +1 more person who would appreciate this

datsoy commented 3 years ago

update for arm64 image?

MatthewVance commented 3 years ago

This is an enhancement I would like to provide, modeling after @pedantic79's use of GH actions. Life and work has kept this from being a priority. For now, the https://github.com/MatthewVance/unbound-docker-rpi is available. I know that's not ideal. It would also be better for me to only maintain one repo that supports both formats.

pedantic79 commented 3 years ago

update for arm64 image?

I've been using https://hub.docker.com/r/pedantic/unbound which uses my GH action to build the arm64/amd64 based on the latest copy of the repo. I have a cronjob running every night that syncs my git repo with MatthewVance's and then attempts to rebase my action on top, then publish it to my repo. This way if there's an update it'll build it as well.

Tonight, I updated the action to check for the latest version (currently 1.13.1) rather than hardcoding it. Sorry, but no extra tags, just have latest.

datsoy commented 3 years ago

This is an enhancement I would like to provide, modeling after @pedantic79's use of GH actions. Life and work has kept this from being a priority. For now, the https://github.com/MatthewVance/unbound-docker-rpi is available. I know that's not ideal. It would also be better for me to only maintain one repo that supports both formats.

no problem, life/family comes first

update for arm64 image?

I've been using https://hub.docker.com/r/pedantic/unbound which uses my GH action to build the arm64/amd64 based on the latest copy of the repo. I have a cronjob running every night that syncs my git repo with MatthewVance's and then attempts to rebase my action on top, then publish it to my repo. This way if there's an update it'll build it as well.

Tonight, I updated the action to check for the latest version (currently 1.13.1) rather than hardcoding it. Sorry, but no extra tags, just have latest.

Great! thank you. this worked, tried others but didnt work.

maintain3r commented 3 months ago

Hello there, Is there official unbound and nsd dns software versions?