update hapi v2.2 to v2.3

MatthewVita / node-hl7-complete

Node module that is bridged with the Java Hapi HL7 library.

55 stars 12 forks source link

update hapi v2.2 to v2.3 #16

Closed privateOmega closed 3 years ago

privateOmega commented 3 years ago

This would allow us to cover a lot more hl7 messages and probably there's an improvement in performance underneath as well.

MatthewVita commented 3 years ago

(Generic message on recent conversations: I'll be looking at your posts/PR more closely this weekend. Crazy week ahead for me!)

Great. Thanks for the upgrade. I'm excited to hear we'll have ever better HL7 coverage in our project!

Also, thanks for researching the HL7 differences too... I know that coding is not always the main activity ha.

If the test/functional tests run, feel free to merge. (You should be an co-maintainer of the project now),

privateOmega commented 3 years ago

@MatthewVita Thanks for the collaborator access. Out of curiousity, did you name the node-hl7-complete jar file version based on some logic? Should it follow the same version as the node package? I am a bit apprehensive on the v3 - v4 jump for the jar.