search

MatthewVita / node-hl7-complete

Node module that is bridged with the Java Hapi HL7 library.
54 stars 13 forks source link

disabling slf4j #17

Open privateOmega opened 3 years ago

privateOmega commented 3 years ago

Is the slf4j dependency mandatory? If we could disable it, that would be great.

SLF4J: Failed to load class "org.slf4j.impl.StaticLoggerBinder".
SLF4J: Defaulting to no-operation (NOP) logger implementation
SLF4J: See http://www.slf4j.org/codes.html#StaticLoggerBinder for further details.

this log is sort of annoying. @MatthewVita Anything we could possibly do?

MatthewVita commented 3 years ago

(Generic message on recent conversations: I'll be looking at your posts/PR more closely this weekend. Crazy week ahead for me!)

Thanks for bringing this up.

This was there since the initial commit 5 years back (time goes fast!). It may matter? I'll check it out. We don't want noise.

MatthewVita commented 3 years ago

@privateOmega Sorry for not reaching out last last. My work deadline is approaching my cat is currently dealing with a breathing problem (lots of exams and vet visits). I'll make time this weekend to continue our conversations/test things out here.