search

MatthewVita / node-hl7-complete

Node module that is bridged with the Java Hapi HL7 library.
54 stars 13 forks source link

Dockerized HTTP server #23

Closed privateOmega closed 3 years ago

privateOmega commented 3 years ago

@MatthewVita PTAL at my dockerize approach, I hope this should suffice.

MatthewVita commented 3 years ago

@privateOmega Hi. I added my bits. Please let me know if it looks good.

MatthewVita commented 3 years ago

I won't have time to look into this immediately, but I wanted to point out that there may be a bug somewhere. See the "UNKNOWN"s. Just posting this more as a reminder for myself. Feel free to ignore.

issue

privateOmega commented 3 years ago

@privateOmega Hi. I added my bits. Please let me know if it looks good.

Thanks for filling in the README, I completely forgot about that.

privateOmega commented 3 years ago

All looks good, I am merging it into your branch.

privateOmega commented 3 years ago

@MatthewVita I've crossposted it as #24

MatthewVita commented 3 years ago

@privateOmega thanks for reviewing. Okay to merge (and maybe bump)?

I saw the crosspost. I won't have time to look at this for a few days. Obviously very important and the tests are clearly not serving us.

privateOmega commented 3 years ago

@privateOmega thanks for reviewing. Okay to merge (and maybe bump)?

I saw the crosspost. I won't have time to look at this for a few days. Obviously very important and the tests are clearly not serving us.

Yup I guess it's good to merge. Bump we have to do it considering npm won't allow deploying same version again, maybe patch update only considering it doesn't modify any functionality and is just addon, and some doc changes.