Wrong Arabic localization

MatthewYork / DateTools

Dates and times made easy in iOS

MIT License

7.22k stars 950 forks source link

Wrong Arabic localization #125

Open Mazyod opened 9 years ago

Mazyod commented 9 years ago

Unfortunately, the Arabic localization is subpar due to Arabic's different counting principles. Here is a comparison table:

count	EN	AR
1	singular (minute)	singular (دقيقة)
2	plural (minutes)	dual (دقيقتان)
3 - 10	plural (minutes)	plural (دقائق)
11+	plural (minutes)	singular (دقيقة)

This can be solved using localization strings dictionary. I'll try to submit a PR, but just documenting the issue for now.

MatthewYork commented 9 years ago

A PR would be great. Thanks!

Mazyod commented 9 years ago

after doing some research, I have found the following:

It seems that the functionality was added in iOS 7 and OS X 10.9
Adding support would fix grammar rules for probably all locales, not just Arabic
I suggest we add a very light weight dependency, or copy the files from it (library).

So, @MatthewYork, what are your thoughts about compatibility and the dependency?

saper commented 7 years ago

Same for Slavic languages. I am a bit surprised that date/time localization library does not have any plural support... it is like writing "1 hour(s)" in English. I can see that you have made an exception for English with singular ("An hour" and "2 hours") - what is needed is something like a proper plural support.

CLDR might help with it! http://cldr.unicode.org/

musbaalbaki commented 7 years ago

Any update on this please? Is there any alternative?