MatthewYork / DateTools

Dates and times made easy in iOS
MIT License
7.22k stars 952 forks source link

Feature/migrate to xcode 10 2 #279

Closed georgescumihai closed 4 years ago

georgescumihai commented 5 years ago

This PR fixed the warnings that are generated with Xcode10.2 Redundant declaration of public when extension are public.

Resolves the warnings for SwiftExample sample project to migrate to Swift 4.2 and remove SWIFT_SWIFT3_OBJC_INFERENCE.

What this PR doesn't fix is the localization warnings for generated in Xcode10.2.

georgescumihai commented 5 years ago

@MatthewYork Have a look at the PR please

MatthewYork commented 4 years ago

Visibility modifiers have been taken care of in release 5.0.0 as well as a full migration to Swift 5. There were a lot of problems with the repo in general since I have been gone so long. Everything should be relatively up to date now with a new Cocoapod issued as well.