search

MatthewYork / DateTools

Dates and times made easy in iOS
MIT License
7.22k stars 952 forks source link

Swiftpm support #285

Closed maniramezan closed 4 years ago

maniramezan commented 5 years ago

Fix the issue with SwiftPM setup and add auto generated files to .gitignore

bryan1anderson commented 5 years ago

@maniramezan This fails at return Bundle(path: NSString(string: assetPath).appendingPathComponent("DateTools.bundle"))! Force unwrap a nil optional. Are bundles allowed in SwiftPM at the moment? I didn't think resource files were allowed

maniramezan commented 5 years ago

@bryan1anderson Yeah, so far it's not possible to add bundles to SwiftPM, package manager resources seems to be a proposal for it. For now, it requires to add them manually.

MatthewYork commented 4 years ago

Alright, I have returned. Quit my job, started a business, and had a child....

But definitely ready to merge in SwiftPM support! Please see the recent Swift 5 release and re-evaluate the pull request just to make sure none of my changes bothered yours.

Really appreciate it!

MatthewYork commented 4 years ago

I'm going to close this request. Please reopen branching off the new release and I will merge. Thanks!

maniramezan commented 4 years ago

@MatthewYork Congrats! 🍾🎉

I opened a PR regarding adding SwiftPM https://github.com/MatthewYork/DateTools/pull/291 based on latest master.