refactored: apply some principles like DRY or separation of concerns

MatthewYork / MYBlurIntroductionView

A super-charged version of MYIntroductionView for building custom app introductions and tutorials.

MIT License

1.53k stars 195 forks source link

refactored: apply some principles like DRY or separation of concerns #19

Closed ugort closed 10 years ago

ugort commented 10 years ago

The biggest change is the following:

moved the code for hiding/showing of labels from MYBlurIntroductionView to class MYIntroductionPanel
apply [MYBlurIntroductionView introduction: didFinishWithType:] after animation finished
removed duplicated code in init methods

MatthewYork commented 10 years ago

@ugort I really like the changes you made and am getting ready to merge this. However, when I loaded up the sample application in the repository, it did not build. Is there any way you could fix the elements that have changed (specifically enabling/disabling the introduction view from a custom panel).

Looking forward to the updated example. If everything holds from there, I will merge your changes.

fulldecent commented 10 years ago

I am liking the PR, is there any progress on this code review?

MatthewYork commented 10 years ago

I have not heard from ugort, however I am planning to do a re-write soon with full landscape and iPad support.

fulldecent commented 10 years ago

Very good news, +star!

ugort commented 10 years ago

I did commit an update long time ago. But omitted a comment, maybe because of that you did not notice.