search

Matthias247 / jawampa

Web Application Messaging Protocol (WAMP v2) support for Java
Apache License 2.0
148 stars 56 forks source link

Updated Netty version (current is buggy) #106

Closed Darkless012 closed 7 years ago

Darkless012 commented 7 years ago

Version 4.0.24 is buggy and silents Traceback errors that includes errors giving clue why jawampa is not working on some devices - https://github.com/Matthias247/jawampa/issues/105 It is needed at least version 4.0.26 to properly show Tracebacks. It is safe to update to version 4.0.40 without any other code changes.

I've updated to the latest 4.1.11.Final with single incompatible change - see line 112

Matthias247 commented 7 years ago

Thanks. I think moving to Netty 4.1 is totally reasonable. There was just no stable release when this project was started.

Darkless012 commented 7 years ago

Oh I totally forget to update version number. Would it be possible to update the version number and put it in maven so I can link this lib directly via gradle please? Thank you beforehand.

Matthias247 commented 7 years ago

There's a 0.5.0 release which contains everything. Btw: The changes in the pull request were not sufficient for Netty 4.1. I also needed to add another dependency (netty-handler?) to get it building on my machine. I then also decided to fix the deprecation warnings that the change introduced. You can see that in the commit history.

Darkless012 commented 7 years ago

Well, I also had to include netty-handler, but I thought that this is because I'm downloading it by hand. There is netty-handler included in netty-codec-http pom file: https://github.com/netty/netty/blob/4.1/codec-http/pom.xml So I'm a bit confused.

Anyway, thank you very much :)