search

Matthias247 / jawampa

Web Application Messaging Protocol (WAMP v2) support for Java
Apache License 2.0
148 stars 56 forks source link

exclude_me flag not working as per default #77

Open firaskafri opened 8 years ago

firaskafri commented 8 years ago

Publisher still gets the message without adding the flag "dontExcludeMe" to override the default true exclude_me flag

Matthias247 commented 8 years ago

This needs a bit more background info. Are you using jawampa client or server? And with which peer are you testing?

From a short look at the code I don't see an issue: The client sets exclude_me only to false when the DontExcludeMe flag is set: https://github.com/Matthias247/jawampa/blob/master/jawampa-core/src/main/java/ws/wamp/jawampa/client/SessionEstablishedState.java#L425-L427 The router will by default skip the publisher. Only when the exclude_me flag is set to false it won't skip it: https://github.com/Matthias247/jawampa/blob/master/jawampa-core/src/main/java/ws/wamp/jawampa/WampRouter.java#L871-L880

firaskafri commented 8 years ago

@Matthias247 I'm using:

jawampa-core:0.4.0
netty:0.4.0

With the latest Crossbar server. The client is subscribed to a specific event and when it publishes a message to it the sender still receives the message as if the dontExcludeMe flag was set to true.

Matthias247 commented 8 years ago

If this is the case then it is a Crossbar issue. If you don't set DontExcludeMe then jawampa will send the publish message without an exclude_me: false option to the router. And the router should then not send the event to the publisher. Or do you probably have multiple clients? One which calls publish and the other one receives the event? In such a scenario exclude_me would not affect the second client.

Oh, and jawampa 0.4.1. is the current version.

firaskafri commented 8 years ago

@Matthias247 Yes I do have multiple clients that are subscribed to the same topic and all of them are supposed to receive the publication right.

I'm just talking about the same client which publishes the message. I will look even more deeper into it and update this thread as soon as possible. For now I suggest keeping it open in case someone has the same issue.