Does not re-hide/close after opening via hotkey

MatthiasGrandl / Loungy

Loungy is a WIP launcher in the vein of Spotlight, Alfred, Raycast.

MIT License

1.35k stars 70 forks source link

Does not re-hide/close after opening via hotkey #32

Closed tecandrew closed 2 weeks ago

tecandrew commented 2 weeks ago

Spotlight and Alfred both close and return to the window you had active prior to invoking their hotkey. Would be great if Loungy does this as well 😃

MatthiasGrandl commented 2 weeks ago

Can you elaborate on the behavior you are missing? When I close Loungy with Esc and then reopen with the hotkey, it takes me back to the screen I was on prior to closing. There is however a timer which resets the screen back to the root screen after 90 seconds.

tecandrew commented 2 weeks ago

https://github.com/MatthiasGrandl/Loungy/assets/21319730/bb348788-e4cb-4792-8de4-264b6cb9a3c8

The ability to hide or exit Loungy using the same hotkey to open it like the example video. Both Spotlight and Alfred have this behavior. I can exit using ESC just fine, but would be nice to hide using the same hotkey

interesting find too 🤔 (end of video):

the KeyCaster app i use to record key presses doesn't show the keys when I'm within Loungy

MatthiasGrandl commented 2 weeks ago

Ah ok I get it! Yeah should be no problem to fix. Didn’t consider some people using the same hotkey to toggle their launcher. I always just ESC.

Regarding the keys not showing while in Loungy, I assume it’s because it’s not a native input field? Not sure how I would go about fixing it. Does it work in the Zed editor?

tecandrew commented 2 weeks ago

yep! seems to work in the Zed editor. strange behavior that Loungy doesn't register these clicks

https://github.com/MatthiasGrandl/Loungy/assets/21319730/4341a07e-76d0-4937-badd-e47dd8531a75

MatthiasGrandl commented 2 weeks ago

I implemented this. Was a bit more work than expected, because I had to add some state tracking which command is currently running in the foreground. For example:

I have the clipboard manager open with hotkey (Hyper+V), I want it to close by using the same hotkey.
If I have the root view open and then use the clipboard manager hotkey, I want it to open the clipboard manager and not close the window.

Should be working nicely now.

tecandrew commented 1 week ago

nice! I'll keep a lookout on GH and Brew releases!

MatthiasGrandl commented 1 week ago

nice! I'll keep a lookout on GH and Brew releases!

I still have to fix the release pipeline. MacOS notarization broke somehow and it's impossible to debug :(

MatthiasGrandl commented 1 week ago

It's released now, albeit without notarization, so MacOS might complain about Loungy being untrusted.

tecandrew commented 1 week ago

works! great stuff! had to go to Privacy & Security settings to allow for Loungy to run again because of the notarization issue, but it's okay for now.

still strange how my keyboard presses doesn't show up whenever I invoke Loungy, but it works 🤷‍♂️

https://github.com/MatthiasGrandl/Loungy/assets/21319730/04a9859f-6c23-40c0-8443-99cd6b0424ed