publish each image to its own topic for use in rqt_image or rviz2

MatthiasKillat / ros2_shm_vision_demo

Apache License 2.0

7 stars 3 forks source link

publish each image to its own topic for use in rqt_image or rviz2 #11

Open flynneva opened 2 years ago

flynneva commented 2 years ago

each processing executable should probably have its own topic to publish to
this would enable users to use rqt and rviz2 as well
additional copies would be avoided using iceoryx I think, making the performance gain for the shm_demo.sh even more apparent

ZhenshengLee commented 2 years ago

@flynneva Hi, see you again!

each processing executable should probably have its own topic to publish to

What do you mean about its own topic? rviz2 and rqt_image can only accept the standard sensor_images::msg::Image, rather than ros2_shm_vision_demo/msg/Image.msg

So, there is an idea of developing tools of showing custom defined image msg, which is ugly, but will be useful for debugging.

What do you think?

There will be some PRs about custom image definition conversion from/to opencv image in https://github.com/ZhenshengLee/ros2_shm_msgs , would you like to give it a little reviews?

An invitation has been sent to you though.

flynneva commented 2 years ago

What do you mean about its own topic?

@ZhenshengLee I mean that currently the demo launches its own GUI (non-rqt) window to visualize the images. These images are not published to a topic but rather just shown in the GUI.

We should publish these images to a topic (sensor_msgs::msg::Image most likely) so that we can use normal ROS visualization tools (rqt, rviz, foxglove, etc.)

ZhenshengLee commented 2 years ago

We should publish these images to a topic (sensor_msgs::msg::Image most likely) so that we can use normal ROS visualization tools (rqt, rviz, foxglove, etc.)

Agreed, check the readme of my repo if interested https://github.com/ZhenshengLee/ros2_shm_msgs/blob/master/README.md

There is a component shm_image_bridge for visualization of a shm_image_topic.