search

MatthiasLienhard / flowkey_dl

helper to create sheet music from flowkey songs
MIT License
70 stars 15 forks source link

fix exception while loading images: handle not found resp. content #36

Closed resihoehne closed 9 months ago

resihoehne commented 9 months ago

I was facing some issues when following the current readme. I managed to download sheets after updating the suggested browser console commands ( btw: For the song I used for testing, the image link did not change to the one shown in the sources ) and caught the response content inside the while loop which is returned after the last image. In my test case "No content" was returned. With this, I was able to run the app without any exception again :) I also recommend to suggest using virtual environments when using a local version of the repo.

hannah-jj commented 9 months ago

@resihoehne Do you mean "Not Found"?

resihoehne commented 9 months ago

Indeed, "Not found" is returned. Just a typo in my comment. I correctly added that to the while loop :)