MatthiasPucher / staRdom

staRdom is a package for R to analyse fluorescence and absorbance data of dissolved organic matter (DOM).
21 stars 2 forks source link

absorbance parameter calculation log(10 ->ln(10) #14

Closed Jbruenjes closed 4 years ago

Jbruenjes commented 4 years ago

Hi Matthias,

I have been using this package for a while now, thanks a lot! I had a look into the absorbance parameter calculation and may have found an issue. I am specifically talking about the abs_parms function, where the input for "unit" is in the documentation defined as:

"unit of absorbance data: if "absorbance", absorbance data is multiplied by log(10)= 2.303 for slope calculations"

This is also exactly what the function does, it basically multiplies by log(10), which is 1.

Should it not be multiplied by ln(10), which is equal to 2.303?

Thank you and keep up the good work,

Jonas