Closed MatthiasValvekens closed 2 years ago
Looks like the SoftHSM version in the Ubuntu focal
repo isn't recent enough. Will attempt to run the actions on jammy
instead...
Base: 98.72% // Head: 98.74% // Increases project coverage by +0.01%
:tada:
Coverage data is based on head (
7a20a42
) compared to base (2b478b9
). Patch coverage: 100.00% of modified lines in pull request are covered.
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
Description of the changes
This PR adds support for two new extensions to PDF, ISO/TS 32001 and ISO/TS 32002. The former extends the standard to allow hashes from the SHA-3 family, and the latter clarifies ECDSA support while also adding EdDSA to the list of supported signature algorithms (both Ed25519 and Ed448).
The code in this PR actually contains relatively few functional changes due to the flexible nature of the internal API. The changes can be roughly broken down as follows:
pyhanko-certvalidator
.pyca/cryptography
.Caveats
Currently, using SHA-3 with RSA and DSA requires some creative ASN.1 wrangling. There's an upstream PR over at the
asn1crypto
repo that would resolve most/all of these issues; see wbond/asn1crypto#238. SHA-3 digests with ECDSA should just work out of the box.Checklist
For new features