adilsitos commented 1 year ago

Description of the changes

Add a missing module into the documentation about Signature appearence generation.

Caveats

Just a simple adjustment in the docs

Checklist

Please go over this checklist to increase the chances of your PR being worked on in a timely manner. Deviations are allowed with proper justification (see previous section).

[x] I have read the project's CoC and contribution guidelines.
[x] I understand and agree to the terms in the Developer Certificate of Origin as applied to this contribution.
[x] All new code in this PR has full test coverage.

For documentation contributions (delete if not applicable)

[x] I have built the HTML documentation locally, and verified that the changes behave correctly in-browser.

Additional comments

I really liked this repo! It's helping me a lot, I've been suffering with digital signature in PDFs for months, and now I have a better idea of how everything works. Thanks!

codecov[bot] commented 1 year ago

Codecov Report

Base: 98.40% // Head: 98.40% // No change to project coverage :thumbsup:

Coverage data is based on head (0169312) compared to base (5c1a329). Patch has no changes to coverable lines.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #222 +/- ## ======================================= Coverage 98.40% 98.40% ======================================= Files 80 80 Lines 12820 12820 ======================================= Hits 12616 12616 Misses 204 204 ``` | Flag | Coverage Δ | | |---|---|---| | unittests | `98.40% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Matthias+Valvekens#carryforward-flags-in-the-pull-request-comment) to find out more. Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Matthias+Valvekens). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Matthias+Valvekens)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

MatthiasValvekens commented 1 year ago

Good catch; thanks!

EDIT: the failing lint check seems to be due to a breaking change in Black... ಠ_ಠ. Will merge this and deal with the linting issue separately.

MatthiasValvekens / pyHanko

Add missing module in documentation #222