Closed MatthiasValvekens closed 1 year ago
Patch coverage: 98.43
% and project coverage change: +0.02
:tada:
Comparison is base (
a408c16
) 98.24% compared to head (a391c8b
) 98.27%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
While trying to get coverage on the full diff I found a more thorny issue with how the AdES validator handles algorithm policy failures---I'll fix that on this branch as well.
Description of the changes
The discussion in #228 centres on some files with an LTV configuration that has some interesting properties:
RevInfoArchival
attribute (i.e. not in a DSS), which has no defined role in PAdES.PyHanko's old validation engine can't cope with some of these characteristics. The new AdES validation deals with them mostly correctly, but the status report is confusing because not all of the information that one would expect actually propagates to the status report. This PR fixes some of those issues.
Caveats
Upgrades
pyhanko-certvalidator
to0.21.0
, which includes a minor but breaking change in the exception hierarchy (see the changelog).Checklist
Please go over this checklist to increase the chances of your PR being worked on in a timely manner. Deviations are allowed with proper justification (see previous section).
For new features (delete if not applicable)
For bug fixes (delete if not applicable)