Modernise timezone usage

MatthiasValvekens commented 1 year ago

Description of the changes

Remove dependency on pytz
Add fallback dependency on zoneinfo for older pythons
Get rid of .localize calls (fixes #256)

Checklist

Please go over this checklist to increase the chances of your PR being worked on in a timely manner. Deviations are allowed with proper justification (see previous section).

[x] I have read the project's CoC and contribution guidelines.
[x] I understand and agree to the terms in the Developer Certificate of Origin as applied to this contribution.
[x] All new code in this PR has full test coverage.

For bug fixes (delete if not applicable)

[x] My changes do not affect any public API or CLI semantics.
[x] My PR adds regression tests (i.e. tests that fail if the bug fix is not applied).
[x] All new code in this PR has full test coverage.

(The decrease in coverage is from import statements being removed, which is no big deal)

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.01 :warning:

Comparison is base (9c46e38) 98.13% compared to head (33757f9) 98.13%.

:exclamation: Current head 33757f9 differs from pull request most recent head 27d5df2. Consider uploading reports for the commit 27d5df2 to get more accurate results

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #257 +/- ## ========================================== - Coverage 98.13% 98.13% -0.01% ========================================== Files 104 104 Lines 14537 14535 -2 ========================================== - Hits 14266 14264 -2 Misses 271 271 ``` | Flag | Coverage Δ | | |---|---|---| | unittests | `98.13% <100.00%> (-0.01%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Matthias+Valvekens#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/MatthiasValvekens/pyHanko/pull/257?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Matthias+Valvekens) | Coverage Δ | | |---|---|---| | [pyhanko/pdf\_utils/misc.py](https://codecov.io/gh/MatthiasValvekens/pyHanko/pull/257?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Matthias+Valvekens#diff-cHloYW5rby9wZGZfdXRpbHMvbWlzYy5weQ==) | `96.70% <100.00%> (-0.03%)` | :arrow_down: | | [pyhanko/version.py](https://codecov.io/gh/MatthiasValvekens/pyHanko/pull/257?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Matthias+Valvekens#diff-cHloYW5rby92ZXJzaW9uLnB5) | `100.00% <100.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

MatthiasValvekens commented 1 year ago

CC: @carlsmedstad.

carlsmedstad commented 1 year ago

That was quick! :)

Building https://aur.archlinux.org/packages/python-pyhanko from 33757f9b91fb7dfb7f1802d71bfe208f3446cfd3 works on both my system (with a timezone set) and in an Arch Linux docker image. Solved!

If you don't mind tagging a patch version I'd appreciated. Alleviates the need for me to patch the package.

MatthiasValvekens commented 1 year ago

Will do; I'm on the move today so won't always have time to babysit the release pipeline, but we'll get there :). Thanks!

MatthiasValvekens commented 1 year ago

0.18.1 is out :)

MatthiasValvekens / pyHanko