Remove repeated line and improve naming consistency

dspinellis commented 8 months ago

The line psi = tbs_document.post_sign_instructions needlessly appeared twice in the code.
The first part's output variable is used as output_handle in the second part. Make both names consistent.

Description of the changes

Small documentation fix in the interrupted signing example code.

Checklist

Please go over this checklist to increase the chances of your PR being worked on in a timely manner. Deviations are allowed with proper justification (see previous section).

[x] I have read the project's CoC and contribution guidelines.
[x] I understand and agree to the terms in the Developer Certificate of Origin as applied to this contribution.
[x] All new code in this PR has full test coverage.

For documentation contributions (delete if not applicable)

[x] I have built the HTML documentation locally, and verified that the changes behave correctly in-browser.

codecov[bot] commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (7aef45a) 98.83% compared to head (df95c0b) 98.83%. Report is 1 commits behind head on master.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #367 +/- ## ======================================= Coverage 98.83% 98.83% ======================================= Files 113 113 Lines 16289 16289 ======================================= Hits 16099 16099 Misses 190 190 ``` | [Flag](https://app.codecov.io/gh/MatthiasValvekens/pyHanko/pull/367/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Matthias+Valvekens) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/MatthiasValvekens/pyHanko/pull/367/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Matthias+Valvekens) | `98.83% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Matthias+Valvekens#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

MatthiasValvekens commented 8 months ago

Thanks; will merge this.

(EDIT: I fixed the CI issue that was causing your build to fail in the meantime)

dspinellis commented 8 months ago

Thank you for the merge, and thank you even more for pyHanko! With it I wrote a tool to sign PDFs using a remote signature API in just a couple of days.

MatthiasValvekens / pyHanko