MatthiesenXYZ / astro-ghostcms

Easily migrate your Ghost Site to Astro, an Astro Integration that turns your Ghost server into a Headless CMS
https://astro-ghostcms.xyz/
MIT License
21 stars 4 forks source link

FIX Update ghostAPI.ts to use environment URL instead of package URL when available #166

Open HenriquePi opened 1 month ago

HenriquePi commented 1 month ago

Fix setting of ghostURL to use user set URL instead of default

Currently script prioritizes CONF_URL which is a package default.

set CONTENT_API_URL to have priority to ensure user set URL has priority.

changeset-bot[bot] commented 1 month ago

⚠️ No Changeset found

Latest commit: 9755050690733a1c0f416e24e91663614243d63c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Adammatthiesen commented 1 month ago

Hi, The recommended setup is to define the actual ghostURL within your astro.config.mjs instead of .env ( example ) as per our docs as well... since its not considered a protected key/secret by GhostCMS. Though from my own testing it should default to what ever option you have set without needing this change as i do not set a default ghostURL myself.

Side note... I will be rebuilding the Astro-GhostCMS integration system here soon as i have learned a ton from my developing StudioCMS