search

MatthieuBizien / roam-to-git

Automatic RoamResearch backup to Git
MIT License
550 stars 133 forks source link

Backup failed by ValueError: too many values to unpack #60

Closed xiaofeng1986 closed 4 years ago

xiaofeng1986 commented 4 years ago

Describe the bug Github Action backup failed by ValueError: too many values to unpack after 80 successful successful Github actions

To Reproduce Steps to reproduce the behavior: Either allow Git Action to run as scheduled or manual run Git Action

Expected behavior Expected github actions successful with roam file commit

Traceback File "/opt/hostedtoolcache/Python/3.8.6/x64/lib/python3.8/site-packages/roam_to_git/scrapping.py", line 151, in _download_rr_archive output_type_elem, = await document.querySelectorAll(".bp3-text-overflow-ellipsis") │ └ <function Page.querySelectorAll at 0x7fd2e8a1a700> └ <pyppeteer.page.Page object at 0x7fd2e8329370>

https://gist.github.com/xiaofeng1986/9691f3e701bff322ac095ad5961ff3ba

Run roam-to-git --debug notes/ and report what you get. Not quite sure how to do this

Please complete the following information:

georgebashi commented 4 years ago

I'm seeing the same as of 10 hours ago.

mschulz commented 4 years ago

I have been seeing this same error all day today.

leonarpin commented 4 years ago

I have been seeing this same error all day today.

Me too.

TDHTTTT commented 4 years ago

Same here. It might be related to FIrebase outage today as discussed in Roam slack here. However, the outage should be over.

emilras commented 4 years ago

Also failing for me, first failed run: Finished: 2020-10-20 16:22:21 UTC

TDHTTTT commented 4 years ago

After reading the error, and trying querySelect in devTool, it becomes clear to me:

  1. The error occurs when changing download type to json
  2. Somehow Roam has changed CSS class name and this time ".bp3-text-overflow-ellipsis" only has one instead of many matchings Roam introduced EDN and broke it.

I have made a PR #62 to fix this. I have tested in my own backup repo and it seems to work fine.

TDHTTTT commented 4 years ago

Apparently, the breaking change is that Roam introduced a third backup method, EDN. Mehedi Bakht worked on this earlier today at #59. So his PR should also work.

xiaofeng1986 commented 4 years ago

Thanks @TDHTTTT for your quick response, and try github actions using #59 fix in my forked repo. The github action run successfully again.

xiaofeng1986 commented 4 years ago

Closed as #59 already merged