search

MatthieuDartiailh / bytecode

Python module to modify bytecode
https://bytecode.readthedocs.io/
MIT License
302 stars 38 forks source link

support general constants in code object. #33

Closed thautwarm closed 6 years ago

thautwarm commented 6 years ago

32

codecov-io commented 6 years ago

Codecov Report

Merging #33 into master will increase coverage by 0.03%. The diff coverage is 95.83%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #33      +/-   ##
==========================================
+ Coverage   93.58%   93.62%   +0.03%     
==========================================
  Files          17       17              
  Lines        2605     2652      +47     
==========================================
+ Hits         2438     2483      +45     
- Misses        167      169       +2
Impacted Files Coverage Δ
bytecode/tests/test_concrete.py 99.48% <91.66%> (-0.25%) :arrow_down:
bytecode/concrete.py 95.01% <97.22%> (+0.19%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a7cc7a5...66fb0a8. Read the comment docs.

MatthieuDartiailh commented 6 years ago

As mentioned in #32 I believe we can do simpler simply by tweaking the key generation function. If you have some time to look at it, that would be great otherwise I will come back to it but I can make no promise on when.

thautwarm commented 6 years ago

@MatthieuDartiailh Sorry for my delay. Keeping a simple dictionary does make sense, and a corresponding implementation would be presented here recently.