codecov-io commented 6 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@f63b5b9). Click here to learn what that means. The diff coverage is 64.91%.

@@            Coverage Diff            @@
##             master      #41   +/-   ##
=========================================
  Coverage          ?   92.99%           
=========================================
  Files             ?       17           
  Lines             ?     2655           
  Branches          ?        0           
=========================================
  Hits              ?     2469           
  Misses            ?      186           
  Partials          ?        0

Impacted Files	Coverage Δ
bytecode/tests/test_cfg.py	`97.1% <58.82%> (ø)`
bytecode/tests/test_peephole_opt.py	`90.86% <60%> (ø)`
bytecode/instr.py	`93.62% <90%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f63b5b9...29ba6aa. Read the comment docs.

MatthieuDartiailh commented 6 years ago

This was broken by #43

MatthieuDartiailh commented 6 years ago

@serhiy-storchaka could you point me to the bpo discussing the changes in the bytecode that require to change the tests (for my own education) ?

serhiy-storchaka commented 6 years ago

This is mainly https://bugs.python.org/issue17611 (PR https://github.com/python/cpython/pull/5006). SETUP_LOOP no longer used for loops, BREAK_LOOP is replaced with a direct jump, etc. These opcodes have been removed at all.

MatthieuDartiailh commented 6 years ago

I will merge now and open a new issue for updating the documentation. Thanks @serhiy-storchaka

MatthieuDartiailh / bytecode

Support Python 3.8. #41

Codecov Report