search

MatthieuLemoine / electron-push-receiver

A module to bring Web Push support to Electron allowing it to receive notifications from Firebase Cloud Messaging (FCM).
https://medium.com/@MatthieuLemoine/my-journey-to-bring-web-push-support-to-node-and-electron-ce70eea1c0b0
MIT License
191 stars 62 forks source link

Throw errors #12

Open ibash opened 6 years ago

ibash commented 6 years ago

@MatthieuLemoine I made this change so that we can opt-in to throwing errors. We catch these and send them to bugsnag, so it should help with catching any edge cases in the gcm code.

MatthieuLemoine commented 6 years ago

Can't we use NOTIFICATION_SERVICE_ERROR for this ?

ibash commented 6 years ago

I did that at first, but realized I actually wanted the errors in the main process, since that's where I have bugsnag set to catch them. I'm happy for this not to be merged into the main project, as it's kind of an odd use case, and I'm mostly doing it to help flush out any bugs with the changes to push-receiver.

FWIW we're rolling the push-receiver changes, so it'll start getting some production testing :)