search

MatthieuLemoine / electron-push-receiver

A module to bring Web Push support to Electron allowing it to receive notifications from Firebase Cloud Messaging (FCM).
https://medium.com/@MatthieuLemoine/my-journey-to-bring-web-push-support-to-node-and-electron-ce70eea1c0b0
MIT License
191 stars 62 forks source link

increase min electron version #9

Closed CydeSwype closed 6 years ago

CydeSwype commented 6 years ago

I believe async calls require node version 7.6 or higher. electron 1.8.2 bumped node version to include node ^7.6 (see https://github.com/electron/electron/commit/0330a30fdb405d99cddaf2b0529f9ea02086d949#diff-bcf7bcf05ac59e51b9adfd7394c810c4)

When I tried installing electron-push-receiver and running I was getting unexpected token errors on async calls.

MatthieuLemoine commented 6 years ago

That's weird because I have no issue running it with electron 1.8.1

MatthieuLemoine commented 6 years ago

In the link you shared, you can see that node v7.9+ is available in electron since 1.7.3

PedroKantar commented 6 years ago

No issue on my side with Electron 1.7.6

CydeSwype commented 6 years ago

I was having general instability issues (i.e. windows crashing) with electron 1.8.1 so I've reverted back to electron 1.6.15 (latest stable vs. beta) for my project. I'll withdraw this pull request, but maybe consider requiring something more stable than 1.8 line unless that's really required?

MatthieuLemoine commented 6 years ago

@CydeSwype Well it seems that latest 1.7 is enough