search

MatthijsKok / TI2806-Contextproject

GNU Lesser General Public License v3.0
0 stars 0 forks source link

Feature/postpayment #129

Closed RvdK closed 7 years ago

RvdK commented 7 years ago

Allows you to create add a transaction to the bunq account

joskuijpers commented 7 years ago

Could you rebase on develop and push? Then travis should be nicer.

RvdK commented 7 years ago

rebase did not help

joskuijpers commented 7 years ago

Rebase again, after the develop build finished. It should work... (it must :'( )

RvdK commented 7 years ago

merged the extended testing with this pr as they are related

codecov[bot] commented 7 years ago

Codecov Report

Merging #129 into develop will increase coverage by 10.7%. The diff coverage is 86.36%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop     #129      +/-   ##
=============================================
+ Coverage      39.97%   50.67%   +10.7%     
  Complexity         3        3              
=============================================
  Files             37       37              
  Lines            768      809      +41     
  Branches          49       50       +1     
=============================================
+ Hits             307      410     +103     
+ Misses           445      383      -62     
  Partials          16       16
Impacted Files Coverage Δ Complexity Δ
...in/java/nl/tudelft/ewi/ds/bankchain/bank/Bank.java 100% <ø> (ø) 0 <0> (ø) :arrow_down:
...nkchain/activities/RecentTransactionsActivity.java 0% <ø> (ø) 0 <0> (ø) :arrow_down:
...l/tudelft/ewi/ds/bankchain/bank/mock/MockBank.java 22.22% <0%> (-2.78%) 0 <0> (ø)
...ewi/ds/bankchain/bank/bunq/api/PaymentService.java 53.33% <71.42%> (+53.33%) 0 <0> (ø) :arrow_down:
...l/tudelft/ewi/ds/bankchain/bank/bunq/BunqBank.java 95.23% <81.81%> (+41.53%) 0 <0> (ø) :arrow_down:
...ft/ewi/ds/bankchain/bank/bunq/BunqTransaction.java 89.74% <96%> (+89.74%) 0 <0> (ø) :arrow_down:
...ft/ewi/ds/bankchain/bank/bunq/BunqInterceptor.java 92.53% <0%> (+1.49%) 0% <0%> (ø) :arrow_down:
...ewi/ds/bankchain/bank/bunq/api/AccountService.java 25% <0%> (+25%) 0% <0%> (ø) :arrow_down:
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9b43c62...e4001dd. Read the comment docs.