search

MatthijsKok / TI2806-Contextproject

GNU Lesser General Public License v3.0
0 stars 0 forks source link

Many UI tests and refactoring of activities. #136

Closed Ishadijcks closed 7 years ago

Ishadijcks commented 7 years ago

image

Ishadijcks commented 7 years ago

Missed some PMD errors.

codecov[bot] commented 7 years ago

Codecov Report

Merging #136 into develop will decrease coverage by 0.18%. The diff coverage is 0%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop     #136      +/-   ##
=============================================
- Coverage      50.67%   50.49%   -0.19%     
  Complexity         3        3              
=============================================
  Files             37       38       +1     
  Lines            809      812       +3     
  Branches          50       50              
=============================================
  Hits             410      410              
- Misses           383      386       +3     
  Partials          16       16
Impacted Files Coverage Δ Complexity Δ
...nkchain/activities/RecentTransactionsActivity.java 0% <0%> (ø) 0 <0> (ø) :arrow_down:
...elft/ewi/ds/bankchain/activities/MainActivity.java 0% <0%> (ø) 0 <0> (ø) :arrow_down:
.../ewi/ds/bankchain/activities/SettingsActivity.java 0% <0%> (ø) 0 <0> (ø) :arrow_down:
.../bankchain/activities/NewVerificationActivity.java 0% <0%> (ø) 0 <0> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e9f31fc...45221d0. Read the comment docs.

joskuijpers commented 7 years ago

The codecov gives crosses because of a very tiny change in coverage. This is because of needed changes to make the code testable. However, the tests for GUI can't be run on travis :( That means that instead of a 20% increase in coverage, that this PR actually does, it decreases coverage by 0.4%.

We are setting codecov as non required because of the travis issues, and merging this PR.

joskuijpers commented 7 years ago

We are using //TRAVIS @Ignore to magically ignore GUI tests on Travis so that builds succeed. A travis build replaces this with @Ignore. When running locally, the tests will be run.