search

MatthijsKok / TI2806-Contextproject

GNU Lesser General Public License v3.0
0 stars 0 forks source link

Finish crypto package and add transaction parser #140

Closed MatthijsKok closed 7 years ago

joskuijpers commented 7 years ago

Could you add a screenshot of the code coverage in JaCoCo?

codecov[bot] commented 7 years ago

Codecov Report

Merging #140 into develop will decrease coverage by 4.1%. The diff coverage is 42.18%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop     #140      +/-   ##
=============================================
- Coverage      50.49%   46.39%   -4.11%     
  Complexity         3        3              
=============================================
  Files             38       40       +2     
  Lines            812      942     +130     
  Branches          50       72      +22     
=============================================
+ Hits             410      437      +27     
- Misses           386      484      +98     
- Partials          16       21       +5
Impacted Files Coverage Δ Complexity Δ
...delft/ewi/ds/bankchain/bank/TransactionParser.java 0% <0%> (ø) 0 <0> (?)
.../ds/bankchain/bank/bunq/BunqTransactionParser.java 0% <0%> (ø) 0 <0> (?)
...ft/ewi/ds/bankchain/cryptography/Verification.java 0% <0%> (ø) 0 <0> (?)
...tudelft/ewi/ds/bankchain/cryptography/ED25519.java 61.53% <100%> (+5.01%) 0 <0> (ø) :arrow_down:
...i/ds/bankchain/cryptography/ChallengeResponse.java 80% <80%> (ø) 0 <0> (?)
.../ewi/ds/bankchain/activities/SettingsActivity.java 0% <0%> (ø) 0% <0%> (ø) :arrow_down:
...elft/ewi/ds/bankchain/activities/MainActivity.java 0% <0%> (ø) 0% <0%> (ø) :arrow_down:
...nkchain/activities/RecentTransactionsActivity.java 0% <0%> (ø) 0% <0%> (ø) :arrow_down:
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3eb95a9...8737679. Read the comment docs.

joskuijpers commented 7 years ago

Wut. The coverage should have increased. And it was increasing, and now codecov changed again.

The merge of develop into this branch caused the activities to run in codecov as well. Same issue with GUI tests.

joskuijpers commented 7 years ago

CodeCov has been removed because it broke.