search

MatthijsKok / TI2806-Contextproject

GNU Lesser General Public License v3.0
0 stars 0 forks source link

Verification improvements #143

Closed MatthijsKok closed 7 years ago

MatthijsKok commented 7 years ago

Please review thouroughly, a opinion on throwing versus catching is appreciated :)

codecov-io commented 7 years ago

Codecov Report

Merging #143 into develop will decrease coverage by 0.76%. The diff coverage is 12.06%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop     #143      +/-   ##
=============================================
- Coverage      49.26%   48.49%   -0.77%     
  Complexity         3        3              
=============================================
  Files             40       40              
  Lines            887      899      +12     
  Branches          66       66              
=============================================
- Hits             437      436       -1     
- Misses           429      441      +12     
- Partials          21       22       +1
Impacted Files Coverage Δ Complexity Δ
.../ds/bankchain/bank/bunq/BunqTransactionParser.java 0% <0%> (ø) 0 <0> (ø) :arrow_down:
.../bankchain/activities/NewVerificationActivity.java 0% <0%> (ø) 0 <0> (ø) :arrow_down:
...i/ds/bankchain/cryptography/ChallengeResponse.java 75% <0%> (-5%) 0 <0> (ø)
...nl/tudelft/ewi/ds/bankchain/bank/IBANVerifier.java 91.66% <100%> (-0.65%) 0 <0> (ø)
...tudelft/ewi/ds/bankchain/cryptography/ED25519.java 44.44% <24%> (-17.1%) 0 <0> (ø)
...elft/ewi/ds/bankchain/cryptography/Verification.kt 0% <0%> (ø) 0% <0%> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 345ecee...a0ff7a2. Read the comment docs.