search

MatthijsKok / TI2806-Contextproject

GNU Lesser General Public License v3.0
0 stars 0 forks source link

Convert some classes to kotlin #147

Closed MatthijsKok closed 7 years ago

MatthijsKok commented 7 years ago

Fixes #148

MatthijsKok commented 7 years ago

This greatly reduces our code size, and in my opinion simplifies a lot of our boilerplate code. I would love your opinion on this

codecov-io commented 7 years ago

Codecov Report

Merging #147 into develop will decrease coverage by 0.75%. The diff coverage is 87.27%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop     #147      +/-   ##
=============================================
- Coverage      49.43%   48.67%   -0.76%     
  Complexity         3        3              
=============================================
  Files             40       40              
  Lines            884      869      -15     
  Branches          66       67       +1     
=============================================
- Hits             437      423      -14     
+ Misses           426      424       -2     
- Partials          21       22       +1
Impacted Files Coverage Δ Complexity Δ
.../ds/bankchain/bank/bunq/BunqTransactionParser.java 0% <0%> (ø) 0 <0> (ø) :arrow_down:
...nkchain/activities/RecentTransactionsActivity.java 0% <0%> (ø) 0 <0> (ø) :arrow_down:
.../tudelft/ewi/ds/bankchain/bank/bunq/BunqAccount.kt 100% <100%> (ø) 0 <0> (?)
...l/tudelft/ewi/ds/bankchain/bank/bunq/BunqBank.java 95.23% <100%> (ø) 0 <0> (ø) :arrow_down:
...nl/tudelft/ewi/ds/bankchain/bank/bunq/BunqParty.kt 85.71% <85.71%> (ø) 0 <0> (?)
...elft/ewi/ds/bankchain/bank/bunq/BunqTransaction.kt 90.62% <90.62%> (ø) 0 <0> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 25297be...c1383ba. Read the comment docs.