search

MatthijsKok / TI2806-Contextproject

GNU Lesser General Public License v3.0
0 stars 0 forks source link

Add session storage #151

Closed joskuijpers closed 7 years ago

joskuijpers commented 7 years ago

A long overdue PR.

GUI tests don't run on my side, no idea why. Have been trying to fix this for over a week.

The whole storage is not easy. It is secure now though. Required some changes with the environment.

codecov-io commented 7 years ago

Codecov Report

Merging #151 into develop will decrease coverage by 1.06%. The diff coverage is 48.71%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop     #151      +/-   ##
=============================================
- Coverage      47.95%   46.89%   -1.07%     
  Complexity         3        3              
=============================================
  Files             39       39              
  Lines            880      981     +101     
  Branches          67       75       +8     
=============================================
+ Hits             422      460      +38     
- Misses           435      496      +61     
- Partials          23       25       +2
Impacted Files Coverage Δ Complexity Δ
.../java/nl/tudelft/ewi/ds/bankchain/Environment.java 90.69% <ø> (ø) 0 <0> (ø) :arrow_down:
...ft/ewi/ds/bankchain/bank/bunq/BunqInterceptor.java 92.53% <ø> (ø) 0 <0> (ø) :arrow_down:
...nkchain/activities/RecentTransactionsActivity.java 0% <0%> (ø) 0 <0> (ø) :arrow_down:
.../nl/tudelft/ewi/ds/bankchain/bank/BankFactory.java 87.5% <100%> (+1.78%) 0 <0> (ø) :arrow_down:
...udelft/ewi/ds/bankchain/bank/bunq/BunqSession.java 55.33% <37.68%> (-36.77%) 0 <0> (ø)
.../tudelft/ewi/ds/bankchain/bank/bunq/BunqTools.java 62.5% <56.66%> (-12.5%) 0 <0> (ø)
...l/tudelft/ewi/ds/bankchain/bank/bunq/BunqBank.java 94.2% <84.61%> (-1.04%) 0 <0> (ø)
...delft/ewi/ds/bankchain/bank/bunq/api/ApiError.java 25.8% <0%> (-29.04%) 0% <0%> (ø)
...in/bank/bunq/retrofit/Java8CallAdapterFactory.java 42.22% <0%> (+4.44%) 3% <0%> (ø) :arrow_down:
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update febe60d...67dad1a. Read the comment docs.

joskuijpers commented 7 years ago

Alright! Can someone review this, I want to merge it