Closed RvdK closed 7 years ago
I reviewed this already with you, live, with many changes (see the commits).
GUI tests need fixing. And some new tests are needed. Other than that, good.
Better code has some issues with our new classes because of coupling however we are of the opinion that decreasing the coupling would create complexity therefore defeating its original purpose
"decreasing the coupling would create complexity" by requiring abstract factories, interfaces with only one implementation and more.
Merging #164 into develop will decrease coverage by
0.91%
. The diff coverage is31.63%
.
@@ Coverage Diff @@
## develop #164 +/- ##
=============================================
- Coverage 43.67% 42.76% -0.92%
Complexity 3 3
=============================================
Files 41 42 +1
Lines 1060 1230 +170
Branches 75 89 +14
=============================================
+ Hits 463 526 +63
- Misses 569 675 +106
- Partials 28 29 +1
Impacted Files | Coverage Δ | Complexity Δ | |
---|---|---|---|
...nkchain/activities/RespondToChallengeActivity.java | 0% <0%> (ø) |
0 <0> (ø) |
:arrow_down: |
...s/bankchain/activities/VerifyResponseActivity.java | 0% <0%> (ø) |
0 <0> (ø) |
:arrow_down: |
.../bankchain/activities/NewVerificationActivity.java | 0% <0%> (ø) |
0 <0> (ø) |
:arrow_down: |
...n/java/nl/tudelft/ewi/ds/bankchain/BankTeller.java | 0% <0%> (ø) |
0 <0> (?) |
|
...elft/ewi/ds/bankchain/activities/MainActivity.java | 0% <0%> (ø) |
0 <0> (ø) |
:arrow_down: |
...udelft/ewi/ds/bankchain/blockchain/Blockchain.java | 86.11% <86.11%> (ø) |
0 <0> (?) |
|
...tudelft/ewi/ds/bankchain/cryptography/ED25519.java | 47.22% <0%> (+2.77%) |
0% <0%> (ø) |
:arrow_down: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 28ef50a...5d59c83. Read the comment docs.
adds blockchain and buisness logic