search

MattiDragon / ExtendedDrawers

Adds drawers and more
Other
6 stars 14 forks source link

[Bug]: Threshold Switch (from the Create mod) not reading drawer capacity correctly #102

Open mkern1200 opened 6 months ago

mkern1200 commented 6 months ago

Description of the issue

Hello! I'm using this mod on my Fabric server for Minecraft 1.20.1. I'm not sure if this is a new issue due to an update or if this has been the case for some time without me noticing, but I have the Create mod installed on my server as well. One of the blocks in that mod is a "threshold switch", which outputs a redstone signal when the adjacent block is filled to a configurable capacity.

I realized today that some of my drawers are not being read correctly by the threshold switch (which may be a Create mod issue instead, I'm not sure). When I set up my drawer network with a threshold switch attached to some drawers, and then begin putting items in via an access point, it seems to glitch out the threshold switch, saying the drawer is 100% full when there are only a few hundred items in it. I can't really figure out what's causing this, but I'm hoping you might be able to help with it?

Reproduction steps

  1. Place a drawer (any type) with a threshold switch attached to it.
  2. Begin putting items into the drawer.
  3. It seems that each slot on the drawer is considered to hold one stack of items (however many the item can stack to, i.e. 1 for tools, 16 for ender pearls, 64 for stone, etc.). Once a single drawer has one stack of items the threshold switch will show it's 100% full, a double drawer with one stack of items will show as 50% full, and a quad drawer with one stack of items will show as 25% full.

Mod version

2.1.1 (Fabric)

Operating System

Windows 11

Minecraft version

1.20.1

Other mods

Fabric loader 0.15.7 Fabric API 0.92.0 Create (Fabric) 0.5.1-f (build 1417)

Server

Happens

Client

Happens

Logs

Nothing appears in the logs related to this issue

Extra Context

No response

MattiDragon commented 6 months ago

This is almost certainly fully on create to fix. Extended drawers implements the transfer api correctly.

Roger-Roger-debug commented 4 months ago

Should be fixed as of https://github.com/Fabricators-of-Create/Create/commit/84f54d7baa1d7c5d95a090eb329ede4b3fae2db2