MattiDragon / ExtendedDrawers

Adds drawers and more
Other
5 stars 10 forks source link

[Feature]: 3D models for the drawers #113

Open Fabsian10000 opened 3 weeks ago

Fabsian10000 commented 3 weeks ago

Description of the feature

add an option for alternate models for the drawers or just replace the existing ones with models with more depth if needed i can gladly provide them if that would make the process easier, and i dont need to be mentioned in any way, i just wanna add a bit to the project.

image

i got the idea from when i was making said models for a resource pack i was making, specifically for a modpack of mine. however i didnt like how the elements such as the item ammount indicator was floating in mid-air so... here i am going all out and writing a feature suggestion for my little inconvenience to make it someone elses problem haha.

The models are fully custom made by me, and do not require any additional texture work as they only use the already existing textures. they are already optimised and cull perfectly, thus they should be easy to implement. again the only thing that i cannot modify is the placement of all the indicators, Icons and other elements shown at the front of the block, these would have to be placed slightly forther back and perhaps downscaled slightly so to not clip into the brim of the model.

How does it make the mod better?

looks neat lol idk

other than that, the new brim of the block give the icons for the upgrades a new place to be. in addition to that it could be made so that they only show up when hovering over them, so as to not impact the asthetic of the block itself

MattiDragon commented 3 weeks ago

I like the idea, but I'd have to figure out how to make a resource pack able to modify the location of the drawer display. I think having indented models by default is a good idea, but I'd still want to provide the option to revert using a resource pack.

When I get to doing this I'd like to use your models, don't really care how you send them over.

Fabsian10000 commented 3 weeks ago

i think it might be possible to display the drawer info as an overlay to a transparent texture or transparent model part of the block. that way you would be able to define a place for the display in the model file itself, by giving the specific model part a specific name such as "display_layer_0" for the item, "display_layer_1" for the number and "display_layer_2" for the upgrades. im no programmer but i believe these model parts are adressable through some coding and thus you should be able to print some images on there, such as the items icon, the stack ammount or the upgrades

Fabsian10000 commented 3 weeks ago

Here is a preview of how the model could look, with some placeholder textures to represent the corrosponding display layers. these layers would be entirely transparent in the final version, and only exist as a blank canvas to print the graphics of the actual displays onto when rendering them ingame

https://github.com/MattiDragon/ExtendedDrawers/assets/112748515/effd65de-6621-4042-b451-b6158d326cd4

MattiDragon commented 3 weeks ago

While it might seem like a nice solution, using a model part here would be really hard to do. Drawer contents are rendered using a block entity renderer, which is fully separate from the model. I'll probably just add a json file resource packs can override.

Fabsian10000 commented 2 weeks ago

i understand if that might also not be a really usable idea, but i was thinking since the model file would already be in a json format this method could at least be used to determine the position of the display. afterall if you just use another jpeg, wouldnt it basically be used in the exact same way, just making it seperated into 2 files?

anyway tho, just a suggestion, im sure there might be other things this would impact, i was just thinking, doing it this way would give people the oppertunity to see what it is gonna look like in the end in the block model editor they use, making it maybe a bit more intuitive, but i understand if thats not a priority