MattiDragon / ExtendedDrawers

Adds drawers and more
Other
6 stars 14 forks source link

[Bug]: Compacting drawer taking in more than it should've been able to #69

Closed kevintok closed 1 year ago

kevintok commented 1 year ago

Description of the issue

2023-06-22_11 42 39 Max should've been 4096 but it's 4099. I was able to reproduce this consistently by using a hopper. I believe this is actually what's causing the crash in https://github.com/MattiDragon/ExtendedDrawers/issues/66 as item went above the limit and when MI tried to insert it returns negative value.

Reproduction steps

  1. Have 4095 clays on the drawer. (1023 clay blocks)
  2. Hopper in a clay block.
  3. Reality: Clay block inserted, allowing clay to go above max
  4. Expected: Clay block not inserted as it has reached maximum

Mod version

v1.4.1

Operating System

Windows 10

Minecraft version

1.19.2

Other mods

No additional mods

Server

Happens

Client

Happens

Logs

no crash in this case, no log

Extra Context

No response