MattiDragon / ExtendedDrawers

Adds drawers and more
Other
5 stars 13 forks source link

[Bug]: Load order dependent mixin conflict with QSL #88

Closed CarlMichaelFabe closed 8 months ago

CarlMichaelFabe commented 9 months ago

Description of the issue

With both Supplementaries and Friends and Foes installed, somehow the compacting drawer doesn't compact clay into clay blocks anymore. This also happens with You've Goat to be Kidding Me mod.

293703326-fac57b28-3187-49af-9e61-b5c9c6f93577

I observed this happening in 2 environments. Written in the Other mods section below.

Reproduction steps

  1. Install mods specified in either environment
  2. Put clay inside compacting drawer

Mod version

2.1.0

Operating System

Windows 11

Minecraft version

1.20.1

Other mods

Environment 1

Environment 2

Server

Happens

Client

Happens

Logs

No crash

Extra Context

No response

MattiDragon commented 8 months ago

What's interesting here is that the compacting recipe for clay is manually added instead of being generated from recipes. For environment 1, are you sure both are required?

encode42 commented 8 months ago

I've tested in another environment to narrow things down! The issue still occurs when only Moonlight Lib is installed.

image

MattiDragon commented 8 months ago

Thanks, this will help a lot with debugging

MattiDragon commented 8 months ago

Update: seems like moonlight lib isn't the issue. Right now looking like QKL is somehow at fault

MattiDragon commented 8 months ago

Figured it out. This is a mod load order dependent mixin incompatibility with QSL. I think you can temporarily fix this by using jvm args to force extended drawers to load before qsl (or the other way, not sure)

CarlMichaelFabe commented 8 months ago

Sorry for the late reply.

For environment 1, are you sure both are required?

From the time I tested it, yes both were required. With only Supplementaries and Moonlight Lib installed, there were no issues, Same with only Friends and Foes. Though it seems Supplementaries and Moonlight Lib have both been updated, so I don't know if it still works in that environment.

Figured it out. This is a mod load order dependent mixin incompatibility with QSL. I think you can temporarily fix this by using jvm args to force extended drawers to load before qsl (or the other way, not sure)

For now, I think I'll just manually add the upacking recipe for clay as a workaround. Changing the mod load order seems a bit too much for me atm and it might mess other things up.

But still, thank you for your time! You can close this now if you want.

MattiDragon commented 8 months ago

I'll close this myself once the issue is solved

MattiDragon commented 8 months ago

Update with a fix releasing soon