search

MattiSG / Watai

Integration testing for the web of components
62 stars 7 forks source link

Add jscs package and basic conf. #119

Closed gillesfabio closed 10 years ago

gillesfabio commented 10 years ago

Add node-jscs package and a basic configuration based on existing code conventions. This configuration needs to be enhanced.

To check the code:

$ npm run lint

There are many "Var declarations" errors (multiple var). Should be fixed.

MattiSG commented 10 years ago

Weird: jscs on npmjs.eu is stuck at v1.3.0.

MattiSG commented 10 years ago

Alright, this was long and tiring, but codebase on the jscs branch is fully linted, jscs is configured, and task is added to exhaustive test suite :)

This is expected to be merged in 0.6.2. It is not merged yet because examples have to be updated first (DuckDuckGo and CheckMyTrip both updated their UI, so tests have to be updated too; these examples are an important validation step, so such a massive codebase change should be checked against them, even though unit and integration tests have passed).

gillesfabio commented 10 years ago

@MattiSG \o/ Great work!

MattiSG commented 10 years ago

Merged in v0.6.2.

v0.6.2 has hit beta phase and has been published, which means it is feature-frozen and awaits positive feedback or one week grace period after last modification, whichever comes first.

MattiSG commented 10 years ago

Released and acknowledged, thanks again! :)