MattiSG / Watai

Integration testing for the web of components
62 stars 7 forks source link

Rename concepts #141

Closed Ndpnt closed 9 years ago

Ndpnt commented 9 years ago

Fixes #116.

MattiSG commented 9 years ago

Great job!

I'm in favor of doing Feature → Scenario too. It is slightly more conventional, and less misleading: good practice would be to have both creation and deletion of an item in the same scenario, as we advise scenarios to be idempotent. It would thus mean two features are tested in the same scenario.

Ndpnt commented 9 years ago

@MattiSG You can re-review, it should be ok now :)

MattiSG commented 9 years ago

I see you rebased, is it safe for me to re-review only Feature → Scenario?

Ndpnt commented 9 years ago

Yes, but also review Changelog.md and package.json

MattiSG commented 9 years ago

Meh. scenario: inside Scenario.js is kinda weird…

Ndpnt commented 9 years ago

@MattiSG For scenario: inside […]Scenario.js, do you prefer steps instead?

MattiSG commented 9 years ago

Yes, that makes perfect sense and is consistent with current architecture! Great suggestion!

MattiSG commented 9 years ago

Done.

Ndpnt commented 9 years ago

I would say: "Each new commit invalid the review" just as we were used to say :). If you ok with that, one more check will be welcome.

MattiSG commented 9 years ago

Proven habits are worth keeping, and god knows we proved it right. I'll handle this ASAP.

MattiSG commented 9 years ago

I find it hard to do reviews on systematically-rebased branches. Could we add commits until GTM, and handle the rebase only after then, possibly confirming no changes happened with a diff?

Or maybe there's a way to handle this I don't know of :)

MattiSG commented 9 years ago

Could you rebase on master now that #144 is merged? I'd prefer to avoid yet another review considering the size of this changeset ;)

Ndpnt commented 9 years ago

Yep, I'm going to handle this :)