Closed Ndpnt closed 9 years ago
Great job!
I'm in favor of doing Feature → Scenario too. It is slightly more conventional, and less misleading: good practice would be to have both creation and deletion of an item in the same scenario, as we advise scenarios to be idempotent. It would thus mean two features are tested in the same scenario.
@MattiSG You can re-review, it should be ok now :)
I see you rebased, is it safe for me to re-review only Feature → Scenario?
Yes, but also review Changelog.md
and package.json
Meh. scenario:
inside Scenario.js
is kinda weird…
@MattiSG For scenario:
inside […]Scenario.js
, do you prefer steps
instead?
Yes, that makes perfect sense and is consistent with current architecture! Great suggestion!
Done.
I would say: "Each new commit invalid the review" just as we were used to say :). If you ok with that, one more check will be welcome.
Proven habits are worth keeping, and god knows we proved it right. I'll handle this ASAP.
I find it hard to do reviews on systematically-rebased branches. Could we add commits until GTM, and handle the rebase only after then, possibly confirming no changes happened with a diff
?
Or maybe there's a way to handle this I don't know of :)
Could you rebase on master
now that #144 is merged? I'd prefer to avoid yet another review considering the size of this changeset ;)
Yep, I'm going to handle this :)
Fixes #116.