Improve UI - Githubissues

MattiSG / adblock

Block ads and trackers system-wide, before a request is even issued.

MIT License

175 stars 13 forks source link

Improve UI #14

Closed MattiSG closed 5 years ago

MattiSG commented 5 years ago

Output number of blocked domains.
Support off alias with double dash prefix.
Remove date warning on macOS.
Decrease amount of information displayed when checking for updates.
Unify punctuation.
Simplify code logic.

MattiSG commented 5 years ago

@odtvince since this slightly touches the disjunction logic you had added to support the GNU version of date, would you be able to try this PR on your setup? 😃

bamthomas commented 5 years ago

tested on ubuntu 16.04 install ok.

MattiSG commented 5 years ago

Thanks for your time @bamthomas! ❤️

Just to be 100% sure that I'm not misunderstanding “install ok”: you've tested on an Ubuntu 16.04 and it worked all right, you haven't just tried to install the script but actually downloaded the blocklist, is that correct? 😃

bamthomas commented 5 years ago

yes, I downloaded the script, and called it with sudo adblock on. Then it downloaded the url blacklist that I've seen added in the /etc/hosts on 0.0.0.0.

MattiSG commented 5 years ago

Thanks @bamthomas! 🙂