Add the ability to install it via homebrew

[davidbgk]

For lazy guys like me, brew install adblock would be great :)

[MattiSG]

Hi David! Glad to see you here :)

I'd also love to brew install adblock. Unfortunately, I cannot do it… but perhaps you can?

We frown on authors submitting their own work unless it is very popular. Source: Brew acceptable formulae.

I considered adding a tap, but I thought that if you need to copy-paste a brew tap one-liner, you might as well copy-paste the full installation command and get rid of the dependency on brew.

I will close this issue for now. If you do create a formula, please mention it here. If you'd prefer that I add a tap, please say it, and I will consider maintaining an additional repo if a few other people weigh in.

[MattiSG]

Another option: get this repo 500+ stars ;)

[davidbgk]

Thanks for your answer and I agree that adding a tap would be as cumbersome as running your install.

Another option: get this repo 500+ stars ;)

That's my new plan ;)

[joelpurra]

@MattiSG: I'd prefer to see a tap! This way users could also be notified when there's an update -- and even have it automatically installed.

I maintain a tap with my own software, and It's not "hard" -- in part because I've chosen to rely on git and git tags (semver style) instead of urls and sha256 hashes. https://github.com/joelpurra/homebrew-joelpurra

[MattiSG]

Thanks @joelpurra! After some struggles with brew documentation, I should have a working tap documented in the brew-tap branch :)

Could you (and possibly @davidbgk) check if everything goes well with rm /usr/local/bin/adblock && brew tap mattisg/mattisg && brew install adblock? :)

[joelpurra]

@MattiSG: Glad to see a tap -- hope it wasn't too much work =)

Below is my shell output. Note that I initially installed adblock without sudo. The conclusion is that switching to brew works well, as brew hints to using both rm ... and brew link ....

brew tap mattisg/mattisg

==> Tapping mattisg/mattisg
Cloning into '/usr/local/Library/Taps/mattisg/homebrew-mattisg'...
remote: Counting objects: 5, done.
remote: Compressing objects: 100% (5/5), done.
remote: Total 5 (delta 0), reused 3 (delta 0), pack-reused 0
Unpacking objects: 100% (5/5), done.
Checking connectivity... done.
Tapped 1 formula (29 files, 120K)

brew install adblock

==> Installing adblock from mattisg/homebrew-mattisg
==> Cloning https://github.com/mattisg/adblock.git
Cloning into '/Library/Caches/Homebrew/adblock--git'...
remote: Counting objects: 7, done.
remote: Compressing objects: 100% (7/7), done.
remote: Total 7 (delta 0), reused 6 (delta 0), pack-reused 0
Unpacking objects: 100% (7/7), done.
Checking connectivity... done.
Note: checking out '08c8f827b0b752a0ca3538e3a0bc90309b123579'.

You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by performing another checkout.

If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -b with the checkout command again. Example:

  git checkout -b <new-branch-name>

==> Checking out tag v1.0.1
Error: The `brew link` step did not complete successfully
The formula built, but is not symlinked into /usr/local
Could not symlink bin/adblock
Target /usr/local/bin/adblock
already exists. You may want to remove it:
  rm '/usr/local/bin/adblock'

To force the link and overwrite all conflicting files:
  brew link --overwrite adblock

To list all files that would be deleted:
  brew link --overwrite --dry-run adblock

Possible conflicting files are:
/usr/local/bin/adblock
==> Summary
🍺  /usr/local/Cellar/adblock/1.0.1: 3 files, 12K, built in 2 seconds

rm '/usr/local/bin/adblock'

brew install adblock

Warning: mattisg/mattisg/adblock-1.0.1 already installed, it's just not linked

brew link adblock

Linking /usr/local/Cellar/adblock/1.0.1... 1 symlinks created

[MattiSG]

Great, thanks for the test! :)

hope it wasn't too much work

It was more than expected, partly because I couldn't find any reference on install_symlink vs install, and none on whether I could add some uninstall hooks… But thanks again for your pointers, I've learned something :)

[davidbgk]

I confirm that it works too! 👍