Error in build: Invalid numeric armument '/Wunused-macros'

[riccardogiussani]

I cloned the repo on my Desktop and run CMake as suggested in the readme. Returned error:

Building Custom Rule C:/Users/user/Desktop/openGJK/CMakeLists.txt
cl : command line error D8021: invalid numeric argument '/Wunused-macros' [C:\Users\user\Desktop\openGJK\build\lib_open
gjk_ce.vcxproj]

[riccardogiussani]

C:\Users\user\Desktop\openGJK>cmake -E make_directory build

C:\Users\user\Desktop\openGJK>cmake -E chdir build cmake -DRUN_UNITESTS=ON  -DCMAKE_BUILD_TYPE=Release ..
-- Building for: Visual Studio 16 2019
CMake Deprecation Warning at CMakeLists.txt:23 (cmake_minimum_required):
  Compatibility with CMake < 2.8.12 will be removed from a future version of
  CMake.

  Update the VERSION argument <min> value or use a ...<max> suffix to tell
  CMake that the project does not need compatibility with older versions.

-- Selecting Windows SDK version 10.0.16299.0 to target Windows 10.0.19043.
-- The C compiler identification is MSVC 19.29.30140.0
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working C compiler: C:/Program Files (x86)/Microsoft Visual Studio/2019/Community/VC/Tools/MSVC/14.29.30133/bin/Hostx64/x64/cl.exe - skipped
-- Detecting C compile features
-- Detecting C compile features - done
-- Version     : 3.0.0
-- Build type  : Release
-- Configuring done
-- Generating done
CMake Warning:
  Manually-specified variables were not used by the project:

    RUN_UNITESTS

-- Build files have been written to: C:/Users/user/Desktop/openGJK/build

C:\Users\user\Desktop\openGJK>cmake --build build
Microsoft (R) Build Engine version 16.11.2+f32259642 for .NET Framework
Copyright (C) Microsoft Corporation. All rights reserved.

  Building Custom Rule C:/Users/user/Desktop/openGJK/CMakeLists.txt
cl : command line error D8021: invalid numeric argument '/Wunused-macros' [C:\Users\user\Desktop\openGJK\build\lib_open
gjk_ce.vcxproj]

[MattiaMontanari]

Thanks for reporting this. I don't have a machine with MSVS installed, but the changes I pushed on master should fix this. @wilwal23 can you please verify that with the latest version the code builds fine?

[riccardogiussani]

Everything works perfectly now :)