search

MattiasBuelens / web-streams-polyfill

Web Streams, based on the WHATWG spec reference implementation
MIT License
285 stars 29 forks source link

Node version bump from 8 to 18 breaks Remix installation #137

Closed Lms24 closed 8 months ago

Lms24 commented 8 months ago

Hi,

seems like version 3.3.0 of web-streams-polyfill bumps engine from Node 8 to Node 18 (https://github.com/MattiasBuelens/web-streams-polyfill/pull/130) which is higher than Remix' minimum Node version (Node 14). This in turn causes our (Sentry Javascript SDKs) integration tests to fail because Remix depends on web-streams-polyfill.

image

IMHO a minimum node version bump should not be made in a minor release. We'll probably be able to work around this issue with overriding the dependency version but just wanted to let you know anyway! (I assume more remix users are going to run into this)

cheers!

AbhiPrasad commented 8 months ago

Remove down-leveling for TypeScript 3.5 or lower

Removing down-leveling is also a breaking change for TS users. Some users are stuck on older TS versions because of transpilation incompatibilities (see https://github.com/getsentry/sentry-javascript/pull/2848 as an example we've run into). Is there appetite in making this a major version instead?

MattiasBuelens commented 8 months ago

Sorry about the inconvenience!

IMHO a minimum node version bump should not be made in a minor release. We'll probably be able to work around this issue with overriding the dependency version but just wanted to let you know anyway! (I assume more remix users are going to run into this)

You're right about the engines bump, I shouldn't have done that. The polyfill should work fine when installed on Node 8, but building the polyfill requires a newer Node version (because of the build dependencies). I'll revert that.

Removing down-leveling is also a breaking change for TS users. Some users are stuck on older TS versions because of transpilation incompatibilities (see getsentry/sentry-javascript#2848 as an example we've run into). Is there appetite in making this a major version instead?

Hmm, I didn't think users would still be using such old TypeScript versions... I'll see what I can do.

feluna commented 8 months ago

Could you release a quick fix version for this? Maybe with the latest commit of 3.2.0? Some production systems are failing to build because of this.

Lms24 commented 8 months ago

whoops, sorry for the auto close, i just merged a workaround in our repo which accidentally closed this issue

MattiasBuelens commented 8 months ago

Version 3.3.1 is out. Can you check if that fixes it?

feluna commented 8 months ago

Yes, it works now. Thank you.

MattiasBuelens commented 8 months ago

Heads-up: I pushed a 3.3.2 release, since 3.3.1 was missing the dist/types/polyfill.d.ts file. 🤦‍♂️

Lms24 commented 8 months ago

Thanks for the quick turnaround!