search

Matticusau / pr-helper

Extremely powerful GitHub Action to streamline management of PRs through automation of common tasks. Very versatile with plenty of configuration settings to adapt to many different implementations.
MIT License
9 stars 1 forks source link

When FrontMatter author is enabled but no author is found it should block auto merge #43

Open Matticusau opened 3 years ago

Matticusau commented 3 years ago

Feature Request

Is your feature request related to a problem? Please describe. When relying on FrontMatter to determine the Author for review. If there is no author key in the FrontMatter we should require reviews or set a default reviewer?

Describe the solution you'd like A default reviewer or block auto merge are possible options

Describe alternatives you've considered Tweaking the review count required might work

Teachability, Documentation, Adoption, Migration Strategy TBA

Matticusau commented 3 years ago

Should also look back into the feature https://github.com/Matticusau/pr-helper/issues/36

Matticusau commented 3 years ago

From some testing it is adding the 'Review Required' label. Provided the minimum review count setting is set, that should block merge until a review is added.

Need to figure out if adding a default reviewer setting is worthwhile functionality.