Extremely powerful GitHub Action to streamline management of PRs through automation of common tasks. Very versatile with plenty of configuration settings to adapt to many different implementations.
MIT License
9
stars
1
forks
source link
PR Helper fails when attempting to assign reviewer who is not a collaborator on Repo #55
Current Behavior
The PR Helper is configured to add reviewers based on specific YAML front-matter. This can also include a configuration lookup file. The issue is that the person being added needs to be a collaborator on the repository. In the event that you remove that persons access you will receive an error and the PR Helper will fail to complete, thus blocking the PR from being merged and requiring manual intervention.
In the event that the addition of the reviewer fails for that reason then it should just be logged and not block the rest of the processing.
To Reproduce
Steps to reproduce the behavior:
Grant someone access to the repo
Set them as a MD file owner in appropriate YAML front-matter
Configure PR Helper as appropriate
Create a PR
See error
Expected behavior/code
In the event that the addition of the reviewer fails for that reason then it should just be logged and not block the rest of the processing.
Additional context/Screenshots
Add any other context about the problem here. If applicable, add screenshots to help explain.
Text based error
Error: Reviews may only be requested from collaborators. One or more of the users or teams you specified is not a collaborator of the ABC/XYZ repository.
Matticusau
commented
2 years ago
Bug Report
Current Behavior The PR Helper is configured to add reviewers based on specific YAML front-matter. This can also include a configuration lookup file. The issue is that the person being added needs to be a collaborator on the repository. In the event that you remove that persons access you will receive an error and the PR Helper will fail to complete, thus blocking the PR from being merged and requiring manual intervention.
In the event that the addition of the reviewer fails for that reason then it should just be logged and not block the rest of the processing.
To Reproduce Steps to reproduce the behavior:
Expected behavior/code In the event that the addition of the reviewer fails for that reason then it should just be logged and not block the rest of the processing.
Additional context/Screenshots Add any other context about the problem here. If applicable, add screenshots to help explain.
Text based error