Mattk70 / Chirpity-Electron

AI powered audio analyser for bird call visualisation, detection and cataloguing
https://chirpity.mattkirkland.co.uk
29 stars 0 forks source link

Export audio clip with audio preferences applied #102

Open Vollpflock opened 5 months ago

Vollpflock commented 5 months ago

Is your feature request related to a problem? Please describe. Very quiet and noisy exported audio clips.

Describe the solution you'd like Apply audio preferences (normalization/volume adjustment, high pass filter, low shelf filter and attenuation) on export. At the moment, these are only audible in the Chirpity UI, and are not applied to exported clips.

Describe alternatives you've considered Exporting as wav and editing in Audacity. Or API upload to Xeno-Canto ;)

Additional context This has already been mentioned under https://github.com/Mattk70/Chirpity-Electron/discussions/60.

Mattk70 commented 5 months ago

Actually, if the filters are enabled when you export, they are applied to the exported audio. With the notable exception of 'normalise'.

When I think about this, I suspect normalise is the only one that should be applied! Otherwise, when you open an exported file with gain / low shelf filters set as before, these filters are applied twice over. If you normalise a file twice, it stays normalised...

Vollpflock commented 5 months ago

And with the second notable exception of "Volume adjustment"? :)

Nah I really appreciate how the high pass filter, low shelf filter, and attenuation are applied during export. It significantly improves the sound quality when sharing files.

Mattk70 commented 5 months ago

Ah, yes. I don't do volume adjustment either. That was probably because of the twice filtered issue I mentioned. It hurt my ears!

Vollpflock commented 5 months ago

Yeah, most of my files don't get fully normalized (at least that's what I call it; they do get somewhat normalized but still aren't louder), so I've set the volume adjustment to +50 dB for now.

Vollpflock commented 5 months ago

If feasible, could you also do this for 'Volume Adjustment' so that the Volume Adjustment filter is applied to exported audio, if enabled and active?

Mattk70 commented 5 months ago

I'd prefer to get to the bottom of why normalisation doesn't do what it's supposed to for your files! If Audacity does it right, there must be another ffmpeg setting I'm not familiar with

Vollpflock commented 5 months ago

Yeah not sure what it is, but Audacity actually normalizes them.